Fix BIOTest.InvokeConnectCallback test. #1433
Conversation
|
I supposed it doesn't matter as long as the connection fails, but I would prefer the test connecting to a non-privileged port (>= 1024). Something arbitrary and not in common use (5325 or 9723?). |
Previously, the test tried to connect to localhost on port 8080, which is a frequently used alternative HTTP port, and it failed if there was anything listening on that port. Signed-off-by: Piotr Sikora <piotr@aviatrix.com>
PiotrSikora
force-pushed
the
fix-bio_callback-test
branch
from
e68e439
to
671bc99
Compare
I intentionally selected privileged port, since it's less likely that there will be something random listening on it, but sure, changed to port 5325. |
|
Could you re-kick |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
==========================================
- Coverage 76.85% 76.84% -0.01%
==========================================
Files 425 425
Lines 71527 71527
==========================================
- Hits 54974 54968 -6
- Misses 16553 16559 +6 ☔ View full report in Codecov by Sentry. |
Description of changes:
Fix BIOTest.InvokeConnectCallback test.
Previously, the test tried to connect to localhost on port 8080, which
is a frequently used alternative HTTP port, and it failed if there was
anything listening on that port.
Call-outs:
N/A
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.